diff options
| author | Kane York <kanepyork@gmail.com> | 2020-07-28T02·57-0700 |
|---|---|---|
| committer | kanepyork <rikingcoding@gmail.com> | 2020-08-01T01·15+0000 |
| commit | 1cbffe21f3284fbad10b4ca27b0d8381bd554ff3 (patch) | |
| tree | 921c90af406f009a660bb82eb40324a459bca7b7 /third_party/nix/src/libutil/hash.hh | |
| parent | 2a292c71f40f3592e33534ee6d63eb2ca5221d5e (diff) | |
chore(3p/nix/hash): prefer StatusOr over throwing constructor r/1515
The use of `unwrap_throw` can be used as a later grep target. Change-Id: I8c54ed90c4289f07aecb8a1393dd10204c8bce4e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1493 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
Diffstat (limited to 'third_party/nix/src/libutil/hash.hh')
| -rw-r--r-- | third_party/nix/src/libutil/hash.hh | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/third_party/nix/src/libutil/hash.hh b/third_party/nix/src/libutil/hash.hh index 208615f67b..4ad4ef6ada 100644 --- a/third_party/nix/src/libutil/hash.hh +++ b/third_party/nix/src/libutil/hash.hh @@ -36,12 +36,15 @@ struct Hash { Subresource Integrity hash expression). If the 'type' argument is htUnknown, then the hash type must be specified in the string. */ - Hash(const std::string& s, HashType type = htUnknown); + Hash(std::string_view s, HashType type = htUnknown); /* Status-returning version of above constructor */ - static absl::StatusOr<Hash> deserialize(const std::string& s, + static absl::StatusOr<Hash> deserialize(std::string_view s, HashType type = htUnknown); + // Legacy unwrapper for StatusOr. Throws BadHash. + static Hash unwrap_throw(absl::StatusOr<Hash> hash) noexcept(false); + void init(); /* Check whether a hash is set. */ |