diff options
| author | Griffin Smith <grfn@gws.fyi> | 2020-08-14T02·06-0400 |
|---|---|---|
| committer | glittershark <grfn@gws.fyi> | 2020-08-14T03·06+0000 |
| commit | d1c38d9597e110bef92a548c86a651174bd385dc (patch) | |
| tree | 98d64ac81a4f7ca91ad21f732c84bdc3f73df9cb /third_party/nix/src/libstore/store-api.hh | |
| parent | aef3607bd332a9a6adbb150abe63250745972532 (diff) | |
refactor(tvix): Make Store::buildPaths return a Status r/1649
Make Store::buildPaths return a Status with [[nodiscard]] rather than throwing exceptions to signal failure. This is the beginning of a long road to refactor the entire store API to be status/statusor based instead of using exceptions. Change-Id: I2e32371c95a25b87ad129987c217d49c6d6e0c85 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1745 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
Diffstat (limited to 'third_party/nix/src/libstore/store-api.hh')
| -rw-r--r-- | third_party/nix/src/libstore/store-api.hh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/third_party/nix/src/libstore/store-api.hh b/third_party/nix/src/libstore/store-api.hh index 8d9c6f0861..b1c0b50de3 100644 --- a/third_party/nix/src/libstore/store-api.hh +++ b/third_party/nix/src/libstore/store-api.hh @@ -445,7 +445,8 @@ class Store : public std::enable_shared_from_this<Store>, public Config { output paths can be created by running the builder, after recursively building any sub-derivations. For inputs that are not derivations, substitute them. */ - virtual void buildPaths(const PathSet& paths, BuildMode buildMode = bmNormal); + [[nodiscard]] virtual absl::Status buildPaths(const PathSet& paths, + BuildMode buildMode = bmNormal); /* Build a single non-materialized derivation (i.e. not from an on-disk .drv file). Note that ‘drvPath’ is only used for |