diff options
| author | Griffin Smith <grfn@gws.fyi> | 2020-08-21T22·58-0400 |
|---|---|---|
| committer | glittershark <grfn@gws.fyi> | 2020-08-29T14·29+0000 |
| commit | 74a8c3d3591801eea4ad00c74b98f0043f20d4cc (patch) | |
| tree | ccc3f974b8d79c3ae35e23d529cf77bb066f0cf6 /third_party/nix/src/libstore/mock-binary-cache-store.cc | |
| parent | 059d90dd6dd317b29bde5517901fa95695792d2c (diff) | |
fix(tvix): Chunk the AddTextToStore request r/1736
Rather than sending the entire AddTextToStore request along in a single message, send it in a stream of chunks using the same metadata-first approach we've been using for the other store gRPC requests. This fixes a bug where certain builds could send more data than the maximum gRPC request size (4194304 bytes, it would appear), resulting in a RESOURCE_EXHAUSTED error. The initial chunk size, which is currently constant but should be made dynamic at some point in the future, has been chosen based on the IPC bandwidth delay product for tazjin's desktop, rounded up. Change-Id: I6f0232cdbc98653484816b39855126873fc59a03 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1835 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: kanepyork <rikingcoding@gmail.com>
Diffstat (limited to 'third_party/nix/src/libstore/mock-binary-cache-store.cc')
0 files changed, 0 insertions, 0 deletions