about summary refs log tree commit diff
path: root/third_party/nix/src/libstore/machines.cc
diff options
context:
space:
mode:
authorVincent Ambo <tazjin@google.com>2020-05-25T00·19+0100
committerVincent Ambo <tazjin@google.com>2020-05-25T00·19+0100
commit98299da0fda612b42ab933c47f18163cfef5fa71 (patch)
tree78fc0f1127b5f2336d3e370f342f72f38d5a5ee2 /third_party/nix/src/libstore/machines.cc
parentb371821db59d33851d521d66ba1fb126d388c00f (diff)
refactor(3p/nix/libutil): Replace string2Int & trim functions r/843
Replaces these functions with corresponding functions from Abseil,
namely absl::StripAsciiWhitespace and absl::SimpleAtoi.

In the course of doing this some minor things I encountered along the
way were also refactored.

This also changes the signatures of the various custom readFile
functions to use absl::string_view types.
Diffstat (limited to 'third_party/nix/src/libstore/machines.cc')
-rw-r--r--third_party/nix/src/libstore/machines.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/third_party/nix/src/libstore/machines.cc b/third_party/nix/src/libstore/machines.cc
index 2f1a7289bd84..6472e037d14c 100644
--- a/third_party/nix/src/libstore/machines.cc
+++ b/third_party/nix/src/libstore/machines.cc
@@ -2,6 +2,8 @@
 
 #include <algorithm>
 
+#include <absl/strings/ascii.h>
+#include <absl/strings/string_view.h>
 #include <glog/logging.h>
 
 #include "globals.hh"
@@ -48,14 +50,13 @@ bool Machine::mandatoryMet(const std::set<std::string>& features) const {
 
 void parseMachines(const std::string& s, Machines& machines) {
   for (auto line : tokenizeString<std::vector<std::string>>(s, "\n;")) {
-    trim(line);
     line.erase(std::find(line.begin(), line.end(), '#'), line.end());
     if (line.empty()) {
       continue;
     }
 
     if (line[0] == '@') {
-      auto file = trim(std::string(line, 1));
+      auto file = absl::StripAsciiWhitespace(std::string(line, 1));
       try {
         parseMachines(readFile(file), machines);
       } catch (const SysError& e) {