diff options
author | Vincent Ambo <tazjin@google.com> | 2020-05-20T21·58+0100 |
---|---|---|
committer | Vincent Ambo <tazjin@google.com> | 2020-05-20T21·58+0100 |
commit | 43677021e3c285c2ced2075b918da947e13fcb00 (patch) | |
tree | 261d2ecbc6a9492d6410f9f4e8fd6629f20b49e6 /third_party/nix/src/libstore/download.cc | |
parent | 689ef502f5b0655c9923ed77da2ae3504630f473 (diff) |
refactor(3p/nix): Apply clang-tidy's performance-* fixes r/789
This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
Diffstat (limited to 'third_party/nix/src/libstore/download.cc')
-rw-r--r-- | third_party/nix/src/libstore/download.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/third_party/nix/src/libstore/download.cc b/third_party/nix/src/libstore/download.cc index 752f546a584b..7476dd50b579 100644 --- a/third_party/nix/src/libstore/download.cc +++ b/third_party/nix/src/libstore/download.cc @@ -130,7 +130,7 @@ struct CurlDownloader : public Downloader { } } - void failEx(std::exception_ptr ex) { + void failEx(const std::exception_ptr& ex) { assert(!done); done = true; callback.rethrow(ex); @@ -663,7 +663,7 @@ struct CurlDownloader : public Downloader { } } - void enqueueItem(std::shared_ptr<DownloadItem> item) { + void enqueueItem(const std::shared_ptr<DownloadItem>& item) { if (item->request.data && !hasPrefix(item->request.uri, "http://") && !hasPrefix(item->request.uri, "https://")) { throw nix::Error("uploading to '%s' is not supported", item->request.uri); @@ -858,7 +858,7 @@ void Downloader::download(DownloadRequest&& request, Sink& sink) { } CachedDownloadResult Downloader::downloadCached( - ref<Store> store, const CachedDownloadRequest& request) { + const ref<Store>& store, const CachedDownloadRequest& request) { auto url = resolveUri(request.uri); auto name = request.name; |