feat(3p/nix): remove External values feature r/1527

External values are only useful when using the plugin framework, which we are not interested in carrying forward.

Reverts commit 320659b0cd161249c95e736c3fb309b1a73ea728

Change-Id: Ib4929c349bbb33f16224fc674e94c7b7d5953c6a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1505
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
Reviewed-by: tazjin <mail@tazj.in>

1 files changed, 0 insertions, 12 deletions

diff --git a/third_party/nix/src/libexpr/value-to-xml.cc b/third_party/nix/src/libexpr/value-to-xml.cc
index aba6013f98..921973881f 100644
--- a/third_party/nix/src/libexpr/value-to-xml.cc
+++ b/third_party/nix/src/libexpr/value-to-xml.cc
@@ -163,11 +163,6 @@ static void printValueAsXML(EvalState& state, bool strict, bool location,
       break;
     }
 
-    case tExternal:
-      v.external->printValueAsXML(state, strict, location, doc, context,
-                                  drvsSeen);
-      break;
-
     case tFloat:
       doc.writeEmptyElement(
           "float", singletonAttrs("value", (format("%1%") % v.fpoint).str()));
@@ -178,13 +173,6 @@ static void printValueAsXML(EvalState& state, bool strict, bool location,
   }
 }
 
-void ExternalValueBase::printValueAsXML(EvalState& state, bool strict,
-                                        bool location, XMLWriter& doc,
-                                        PathSet& context,
-                                        PathSet& drvsSeen) const {
-  doc.writeEmptyElement("unevaluated");
-}
-
 void printValueAsXML(EvalState& state, bool strict, bool location, Value& v,
                      std::ostream& out, PathSet& context) {
   XMLWriter doc(true, out);