chore(3p/nix/libexpr): Expose separate insert & "upsert" methods r/818

Reading more through the old code, it seems like the intention
/sometimes/ is to replace values.

1 files changed, 4 insertions, 2 deletions

diff --git a/third_party/nix/src/libexpr/attr-set.hh b/third_party/nix/src/libexpr/attr-set.hh
index 5837b5cbdc9c..6b68b4664a09 100644
--- a/third_party/nix/src/libexpr/attr-set.hh
+++ b/third_party/nix/src/libexpr/attr-set.hh
@@ -50,10 +50,12 @@ class Bindings {
   // Is this attribute set empty?
   bool empty();
 
-  // TODO(tazjin): rename
-  // TODO(tazjin): does this need to copy?
+  // Insert, but do not replace, values in the attribute set.
   void push_back(const Attr& attr);
 
+  // Insert a value, or replace an existing one.
+  void insert_or_assign(const Attr& attr);
+
   // Look up a specific element of the attribute set.
   iterator find(const Symbol& name);