about summary refs log tree commit diff
path: root/third_party/gopkgs
diff options
context:
space:
mode:
authorAspen Smith <root@gws.fyi>2024-07-28T16·50-0400
committerclbot <clbot@tvl.fyi>2024-08-10T15·28+0000
commitd378111d774777f4a5f319946d26e3d481a49870 (patch)
tree50f3f40d24e00ab3f5d9e5a7ea0dc3b543ba34d3 /third_party/gopkgs
parenta6d6fc418de0cdce921698410265fa78ca6b7f23 (diff)
feat(tvix/eval): Store hash in key of interner r/8474
Rather than storing the leaked allocation for the string as the key in
the interner, store the hash (using NoHashHashBuilder). I thought this
would improve performance, but it doesn't:

hello outpath           time:   [736.85 ms 748.42 ms 760.42 ms]
                        change: [-2.0754% +0.4798% +2.7096%] (p = 0.72 > 0.05)
                        No change in performance detected.

but it at least doesn't *hurt* performance, and it *does* avoid an
`unsafe`, so it's probably net good.

Change-Id: Ie413955bdb6f04b1f468f511e5ebce56e329fa37
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12049
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: aspen <root@gws.fyi>
Diffstat (limited to 'third_party/gopkgs')
0 files changed, 0 insertions, 0 deletions