diff options
author | Griffin Smith <grfn@gws.fyi> | 2020-09-01T02·50-0400 |
---|---|---|
committer | glittershark <grfn@gws.fyi> | 2020-09-06T21·12+0000 |
commit | 8b7dcfaebae17947c2b85eb9759d858f08b74852 (patch) | |
tree | 2258a524841932c8842fac1bfacefe57f72d2ad8 /third_party/git/vcs-svn | |
parent | 87bfc53d7bb21b4d3ecaf801f0b28c0e92fbb900 (diff) |
feat(tvix): Write even more build logs to client r/1767
Write *all* build logs (essentially everything that wasn't a DLOG), not just the stdout of the builder, to the client-bound log_sink_ that's threaded through build.cc. These logs are significantly more useful on the client, both when debugging tvix itself and (more importantly) when building things with it. To make this all work, this commit also refactors the passing-around of the log sink in build.cc slightly - the main reference is now owned by the Worker class, which already stores pointers to itself on the Goals it creates, so those Goals can then load the log sink from the Worker. This change was originally made to allow for logging to the log_sink from instance methods of the worker, but actually feels significantly more natural than storing the sink on the goal anyway. Change-Id: I461685bc7f5c0a326054940ac5971b568dd43f8e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1925 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'third_party/git/vcs-svn')
0 files changed, 0 insertions, 0 deletions