diff options
| author | Kane York <kanepyork@gmail.com> | 2020-11-27T01·39-0800 |
|---|---|---|
| committer | kanepyork <rikingcoding@gmail.com> | 2020-11-27T18·34+0000 |
| commit | 0c8c1227f1210a918737369c92d7e443d3d41c96 (patch) | |
| tree | b3bd55757bedc2fb3f9c7ac7be4cb5765580f1e0 /third_party/git/connect.h | |
| parent | 5fb58e23deb28e2060500d347d402c2f48386691 (diff) | |
refactor(tvix): remove signedness conversions by using std::optional r/1931
The different signedness of level and withLevel was causing implicit conversions. Use a nullopt instead of a -1 sentinel value. third_party/nix/src/libexpr/nixexpr.cc:242:21: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions] Change-Id: I7c2cadb6fd6bbff6c5b84028651ad4ebba423297 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2157 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
Diffstat (limited to 'third_party/git/connect.h')
0 files changed, 0 insertions, 0 deletions