about summary refs log tree commit diff
path: root/third_party/gerrit
diff options
context:
space:
mode:
authorProfpatsch <mail@profpatsch.de>2020-06-28T00·56+0200
committerProfpatsch <mail@profpatsch.de>2020-06-29T02·00+0000
commitf28b0d01ef74c0c4e7a305e909bc88bfec0616f4 (patch)
tree5fd15084946e9d6606c60eda72014024859a576c /third_party/gerrit
parent1e71ce8a29c86b0544f4014d7c91bfb0b950a0c8 (diff)
fix(ci-builds): typecheck __allTargets to be (list drv) r/1126
`nix-build -A` expects a list of derivations, otherwise it will
silently skip some targets. We can use yants to ensure we don’t
accidentally put test targets that do not run on CI.

`depot.users.tazjin.blog` was one such target, the only real drv is
in the `rendered` field.

`getBins` is not a derivation, rather the `runTestsuite` prints `{}`
if it succeeds and aborts the evaluation otherwise. We make it into a
derivation, using the `emptyDerivation` primitive we added earlier.
We could actually improve that still, see the TODO.

Change-Id: I3e7658b21aa4ef84192ac43c11b986bd8570a115
Reviewed-on: https://cl.tvl.fyi/c/depot/+/666
Reviewed-by: Profpatsch <mail@profpatsch.de>
Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'third_party/gerrit')
0 files changed, 0 insertions, 0 deletions