about summary refs log tree commit diff
path: root/third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch
diff options
context:
space:
mode:
authorLuke Granger-Brown <git@lukegb.com>2020-11-27T17·39+0000
committerlukegb <lukegb@tvl.fyi>2020-11-29T02·26+0000
commit77be22549a436d0869d8f8c91c09e5b3219567b7 (patch)
tree8765087c25d6867723dcf00c3dd4df5c18907cf2 /third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch
parent36cf7bef24bbd5ffccc8bac47a8c4d10dd5a265c (diff)
chore(3p/gerrit): update to latest upstream HEAD r/1957
Change-Id: Ia7b17ca83ace164881a4dd8b0288741489bc467c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2164
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch')
-rw-r--r--third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch35
1 files changed, 0 insertions, 35 deletions
diff --git a/third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch b/third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch
deleted file mode 100644
index 715c70d70185..000000000000
--- a/third_party/gerrit/0007-Fix-gr-hovercard-behavior-under-Firefox.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From 460d4806feef7fdddc8e3b63dec4fa1854fd2561 Mon Sep 17 00:00:00 2001
-From: Luke Granger-Brown <lukegb@google.com>
-Date: Sat, 25 Jul 2020 23:54:18 +0000
-Subject: [PATCH 7/7] Fix gr-hovercard-behavior under Firefox
-
-Firefox doesn't implement toElement/fromElement (they're not in the
-spec, and were implemented by Chrome apparently for compatibility with
-IE), but does implement target and relatedTarget, which are part of
-the UI Events spec
-(https://w3c.github.io/uievents/#interface-mouseevent).
-
-Bug: Issue 13175
-Change-Id: I9eeb26c032a38de9d7185749373c7982c796acb2
----
- .../app/elements/shared/gr-hovercard/gr-hovercard-behavior.js | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js
-index 04c3166dd5..3d5937b1fa 100644
---- a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js
-+++ b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js
-@@ -209,8 +209,8 @@ export const hovercardBehaviorMixin = superClass => class extends superClass {
-     // from the hovercard but now hovering over the target (to stop an annoying
-     // flicker effect), just return.
-     if (opt_e) {
--      if (opt_e.toElement === this ||
--          (opt_e.fromElement === this && opt_e.toElement === this._target)) {
-+      if (opt_e.relatedTarget === this ||
-+          (opt_e.target === this && opt_e.relatedTarget === this._target)) {
-         return;
-       }
-     }
--- 
-2.27.0
-