diff options
author | Ludovic Courtès <ludo@gnu.org> | 2014-03-18T22·17+0100 |
---|---|---|
committer | Eelco Dolstra <eelco.dolstra@logicblox.com> | 2014-03-18T22·22+0100 |
commit | 51800e06dec91282b81fc41e56d1e9325849d2c2 (patch) | |
tree | 57e25f836e644799107c481d2b622e024917f835 /tests/add.sh | |
parent | f93e97517e449cb1b3c7bdf8076812276b4cb2cd (diff) |
Allow recovery from isValidPath RPCs with an invalid path
Currently, clients cannot recover from an isValidPath RPC with an invalid path parameter because the daemon closes the connection when that happens. More precisely: 1. in performOp, wopIsValidPath case, ‘readStorePath’ raises an ‘Error’ exception; 2. that exception is caught by the handler in ‘processConnection’; 3. the handler determines errorAllowed == false, and thus exits after sending the message. This last part is fixed by calling ‘startWork’ early on, as in the patch below. The same reasoning could be applied to all the RPCs that take one or more store paths as inputs, but isValidPath is, by definition, likely to be passed invalid paths in the first place, so it’s important for this one to allow recovery.
Diffstat (limited to 'tests/add.sh')
0 files changed, 0 insertions, 0 deletions