S3BinaryCacheStore:: Eliminate a string copy while uploading

This cuts hydra-queue-runner's peak memory usage by about a third.

1 files changed, 14 insertions, 0 deletions

diff --git a/src/libutil/util.hh b/src/libutil/util.hh
index 50b96f7ed9..a8f6f99b95 100644
--- a/src/libutil/util.hh
+++ b/src/libutil/util.hh
@@ -431,4 +431,18 @@ void callSuccess(
 }
 
 
+/* A variant of std::istringstream that doesn't its string
+   argument. This is useful for large strings. The caller must ensure
+   that the string object is not destroyed while it's referenced by
+   this object. */
+struct istringstream_nocopy : public std::stringstream
+{
+    istringstream_nocopy(const std::string & s)
+    {
+        rdbuf()->pubsetbuf(
+            (char *) s.data(), s.size());
+    }
+};
+
+
 }