about summary refs log tree commit diff
path: root/src/libstore
diff options
context:
space:
mode:
authorDmitry Kalinkin <dmitry.kalinkin@gmail.com>2017-07-18T21·51-0400
committerDmitry Kalinkin <dmitry.kalinkin@gmail.com>2017-07-18T21·51-0400
commitd5e1bffd2a5b5c39f14944fe3ba25414dcd0d508 (patch)
tree30c1cf3b30256511bb32452c5c3084116356b993 /src/libstore
parent72462b4b6ec94672aad67c6fd4b5c79d2e073d7e (diff)
Do not try to fill fd_set with fd>=FD_SETSIZE
This is UB and causes buffer overflow and crash on linux.
Diffstat (limited to 'src/libstore')
-rw-r--r--src/libstore/build.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
index 60b0a531f423..d2a270259a8c 100644
--- a/src/libstore/build.cc
+++ b/src/libstore/build.cc
@@ -3835,6 +3835,9 @@ void Worker::waitForInput()
     int fdMax = 0;
     for (auto & i : children) {
         for (auto & j : i.fds) {
+            if (j >= FD_SETSIZE) {
+                throw BuildError("reached FD_SETSIZE limit");
+            }
             FD_SET(j, &fds);
             if (j >= fdMax) fdMax = j + 1;
         }