diff options
author | Eelco Dolstra <eelco.dolstra@logicblox.com> | 2014-07-10T09·51+0200 |
---|---|---|
committer | Eelco Dolstra <eelco.dolstra@logicblox.com> | 2014-07-10T09·58+0200 |
commit | 04170d06bf7d17f882c01d3ab98885e0f3e46d2f (patch) | |
tree | 16acb88f8044f865bfbb846df666d622f151301c /src/libstore/build.cc | |
parent | 2c3a8f787ba9da49feafdec4022534184e0a96a3 (diff) |
nix-copy-closure: Fix race condition
There is a long-standing race condition when copying a closure to a remote machine, particularly affecting build-remote.pl: the client first asks the remote machine which paths it already has, then copies over the missing paths. If the garbage collector kicks in on the remote machine between the first and second step, the already-present paths may be deleted. The missing paths may then refer to deleted paths, causing nix-copy-closure to fail. The client now performs both steps using a single remote Nix call (using ‘nix-store --serve’), locking all paths in the closure while querying. I changed the --serve protocol a bit (getting rid of QueryCommand), so this breaks the SSH substituter from older versions. But it was marked experimental anyway. Fixes #141.
Diffstat (limited to 'src/libstore/build.cc')
0 files changed, 0 insertions, 0 deletions