about summary refs log tree commit diff
path: root/src/libmain
diff options
context:
space:
mode:
authorEelco Dolstra <eelco.dolstra@logicblox.com>2014-12-05T19·34+0100
committerEelco Dolstra <eelco.dolstra@logicblox.com>2014-12-05T19·34+0100
commitd34d2b2bbf784c0bb420a50905af25e02c6e4989 (patch)
tree6eb1ba5ea6940a55b475f93618e5511a37f807ff /src/libmain
parentd51eed833a7bbd211a1601367e90d91f71025206 (diff)
Use posix_spawn to run the pager
In low memory environments, "nix-env -qa" failed because the fork to
run the pager hit the kernel's overcommit limits. Using posix_spawn
gets around this. (Actually, you have to use posix_spawn with the
undocumented POSIX_SPAWN_USEVFORK flag, otherwise it just uses
fork/exec...)
Diffstat (limited to 'src/libmain')
-rw-r--r--src/libmain/shared.cc38
1 files changed, 30 insertions, 8 deletions
diff --git a/src/libmain/shared.cc b/src/libmain/shared.cc
index c4b5c210d5be..d0c75a82ac3a 100644
--- a/src/libmain/shared.cc
+++ b/src/libmain/shared.cc
@@ -15,6 +15,7 @@
 #include <sys/stat.h>
 #include <unistd.h>
 #include <signal.h>
+#include <spawn.h>
 
 
 namespace nix {
@@ -305,14 +306,35 @@ RunPager::RunPager()
     Pipe toPager;
     toPager.create();
 
-    pid = startProcess([&]() {
-        if (dup2(toPager.readSide, STDIN_FILENO) == -1)
-            throw SysError("dupping stdin");
-        if (!getenv("LESS"))
-            setenv("LESS", "FRSXMK", 1);
-        execl("/bin/sh", "sh", "-c", pager.c_str(), NULL);
-        throw SysError(format("executing ‘%1%’") % pager);
-    });
+    // FIXME: should do this in the child environment.
+    if (!getenv("LESS"))
+        setenv("LESS", "FRSXMK", 1);
+
+    /* Start the pager using posix_spawn. */
+    pid_t pid_;
+    const char * argv[] = { "sh", "-c", pager.c_str(), 0 };
+
+    posix_spawn_file_actions_t fileActions;
+    int err = posix_spawn_file_actions_init(&fileActions);
+    if (err) throw SysError(err, "creating POSIX file actions");
+    err = posix_spawn_file_actions_adddup2(&fileActions, toPager.readSide, STDIN_FILENO);
+    if (err) throw SysError(err, "adding to POSIX file actions");
+
+    posix_spawnattr_t spawnAttrs;
+    err = posix_spawnattr_init(&spawnAttrs);
+    if (err) throw SysError(err, "creating POSIX spawn attrs");
+#ifdef POSIX_SPAWN_USEVFORK
+    err = posix_spawnattr_setflags(&spawnAttrs, POSIX_SPAWN_USEVFORK);
+    if (err) throw SysError(err, "setting POSIX spawn attr flag");
+#endif
+
+    err = posix_spawn(&pid_, "/bin/sh", &fileActions, &spawnAttrs, (char * const *) argv, environ);
+
+    posix_spawn_file_actions_destroy(&fileActions);
+    posix_spawnattr_destroy(&spawnAttrs);
+
+    if (err) throw SysError(err, format("running ‘%1%’") % pager);
+    pid = pid_;
 
     if (dup2(toPager.writeSide, STDOUT_FILENO) == -1)
         throw SysError("dupping stdout");