about summary refs log tree commit diff
path: root/scratch/deepmind/part_two
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2020-03-27T10·52+0000
committerWilliam Carroll <wpcarro@gmail.com>2020-03-27T10·59+0000
commit514136c99af6f1807f07d23640405764f1c674df (patch)
tree856e8f4bf94fbbda73649a9e5a690641b32cc828 /scratch/deepmind/part_two
parentf4f7f454fa23d0b7f8dd665ec755f1131928f98d (diff)
Run Prettier across projects
Problem:
Prettier was not running when I saved Emacs buffers.

Why?
- prettier-js-mode needs needs node; lorri exposes node to direnv; direnv
  exposes node to Emacs; lorri was not working as expected.

Solution:
Now that I'm using nix-buffer, I can properly expose node (and other
dependencies) to my Emacs buffers. Now Prettier is working.

Commentary:
Since prettier hadn't worked for so long, I stopped thinking about it. As such,
I did not include it as a dependency in boilerplate/typescript. I added it
now. I retroactively ran prettier across a few of my frontend projects to unify
the code styling.

I may need to run...
```shell
$ cd ~/briefcase
$ nix-shell
$ npx prettier --list-different "**/*.{js,ts,jsx,tsx,html,css,json}"
```
...to see which files I should have formatted.
Diffstat (limited to 'scratch/deepmind/part_two')
-rw-r--r--scratch/deepmind/part_two/package-lock.json6
-rw-r--r--scratch/deepmind/part_two/package.json1
-rw-r--r--scratch/deepmind/part_two/top-scores.ts13
3 files changed, 13 insertions, 7 deletions
diff --git a/scratch/deepmind/part_two/package-lock.json b/scratch/deepmind/part_two/package-lock.json
index 94c89c5979c4..340aad9f5ce2 100644
--- a/scratch/deepmind/part_two/package-lock.json
+++ b/scratch/deepmind/part_two/package-lock.json
@@ -28,6 +28,12 @@
       "integrity": "sha512-c3sIjNUow0+8swNwVpqoH4YCShKNFkMaw6oH1mNS2haDZQqkeZFlHS3dhoeEbKKmJB4vXpJucU6oH75aDYeE9g==",
       "dev": true
     },
+    "prettier": {
+      "version": "2.0.2",
+      "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.0.2.tgz",
+      "integrity": "sha512-5xJQIPT8BraI7ZnaDwSbu5zLrB6vvi8hVV58yHQ+QK64qrY40dULy0HSRlQ2/2IdzeBpjhDkqdcFBnFeDEMVdg==",
+      "dev": true
+    },
     "source-map": {
       "version": "0.6.1",
       "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz",
diff --git a/scratch/deepmind/part_two/package.json b/scratch/deepmind/part_two/package.json
index c9ef307ca0ee..1f10668ec861 100644
--- a/scratch/deepmind/part_two/package.json
+++ b/scratch/deepmind/part_two/package.json
@@ -9,6 +9,7 @@
   "author": "William Carroll",
   "license": "MIT",
   "devDependencies": {
+    "prettier": "^2.0.2",
     "ts-node": "^8.6.2",
     "typescript": "^3.7.5"
   }
diff --git a/scratch/deepmind/part_two/top-scores.ts b/scratch/deepmind/part_two/top-scores.ts
index ffed9ae59bc5..79c10c883211 100644
--- a/scratch/deepmind/part_two/top-scores.ts
+++ b/scratch/deepmind/part_two/top-scores.ts
@@ -8,7 +8,7 @@ function sortScores(xs: Array<number>, highest: number): Array<number> {
   }
 
   for (let i = 0; i < xs.length; i += 1) {
-    counts[xs[i]] += 1
+    counts[xs[i]] += 1;
   }
 
   for (let i = highest; i >= 0; i -= 1) {
@@ -22,29 +22,28 @@ function sortScores(xs: Array<number>, highest: number): Array<number> {
   return result;
 }
 
-
 // Tests
-let desc = 'no scores';
+let desc = "no scores";
 let actual = sortScores([], 100);
 let expected = [];
 assertEqual(JSON.stringify(actual), JSON.stringify(expected), desc);
 
-desc = 'one score';
+desc = "one score";
 actual = sortScores([55], 100);
 expected = [55];
 assertEqual(JSON.stringify(actual), JSON.stringify(expected), desc);
 
-desc = 'two scores';
+desc = "two scores";
 actual = sortScores([30, 60], 100);
 expected = [60, 30];
 assertEqual(JSON.stringify(actual), JSON.stringify(expected), desc);
 
-desc = 'many scores';
+desc = "many scores";
 actual = sortScores([37, 89, 41, 65, 91, 53], 100);
 expected = [91, 89, 65, 53, 41, 37];
 assertEqual(JSON.stringify(actual), JSON.stringify(expected), desc);
 
-desc = 'repeated scores';
+desc = "repeated scores";
 actual = sortScores([20, 10, 30, 30, 10, 20], 100);
 expected = [30, 30, 20, 20, 10, 10];
 assertEqual(JSON.stringify(actual), JSON.stringify(expected), desc);