diff options
| author | Vincent Ambo <mail@tazj.in> | 2022-01-14T20·40+0300 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2022-01-14T20·44+0000 |
| commit | 005cd4037a88f491baf6b6d402f961cd2f44594c (patch) | |
| tree | e2167fb06253163c5a93279cf2be577ba0203177 /ops | |
| parent | a5c9b11a6bd1388dfc52b06f1b957a7f9cc654ef (diff) | |
fix(gerrit-tvl): Handle "broken" (skipped) jobs correctly r/3598
by simply skipping them Change-Id: I9cbec3b79469ae01b1873d6a42e990b98cc4110a Reviewed-on: https://cl.tvl.fyi/c/depot/+/4921 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
Diffstat (limited to 'ops')
| -rw-r--r-- | ops/gerrit-tvl/static/tvl.js | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js index b1ce3eda3abb..2c4d7ee4739c 100644 --- a/ops/gerrit-tvl/static/tvl.js +++ b/ops/gerrit-tvl/static/tvl.js @@ -116,6 +116,12 @@ const tvlChecksProvider = { continue; } + // Skip jobs marked as 'broken' (this means they were skipped + // intentionally) + if (job.state === 'broken') { + continue; + } + // TODO(lukegb): add the ability to retry these const checkRun = { patchset: parseInt(build.env.GERRIT_PATCHSET, 10), @@ -150,7 +156,7 @@ const tvlChecksProvider = { } checkRun.statusDescription = statusDescription; - if (['failed', 'broken', 'timed_out'].includes(job.state)) { + if (['failed', 'timed_out'].includes(job.state)) { const result = { // TODO(lukegb): get the log as the message here (the Gerrit // implementation doesn't yet seem to support newlines in message |