about summary refs log tree commit diff
path: root/ops
diff options
context:
space:
mode:
authorLuke Granger-Brown <hg@lukegb.com>2020-08-01T14·30+0000
committerlukegb <lukegb@tvl.fyi>2020-08-02T01·18+0000
commit1094e356df316e28d8b7ee8ef9844d0ec7853872 (patch)
tree0beff15c53ada6ceaa26740be5f0ab49106705a6 /ops
parent173f2c8f76cd3359973456597d2dfff72e023c9b (diff)
fix(besadii): Don't add people back to attention set. r/1537
This uses the not very documented ignore_default_attention_set_rules review API.

Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6782
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1513
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'ops')
-rw-r--r--ops/besadii/main.go210
1 files changed, 7 insertions, 3 deletions
diff --git a/ops/besadii/main.go2 b/ops/besadii/main.go2
index 27dd76b42f89..998c677010bc 100644
--- a/ops/besadii/main.go2
+++ b/ops/besadii/main.go2
@@ -223,9 +223,10 @@ func refUpdatedMain() {
 //
 // https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#review-input
 type reviewInput struct {
-	Message               string         `json:"message"`
-	Labels                map[string]int `json:"labels"`
-	OmitDuplicateComments bool           `json:"omit_duplicate_comments"`
+	Message                        string         `json:"message"`
+	Labels                         map[string]int `json:"labels"`
+	OmitDuplicateComments          bool           `json:"omit_duplicate_comments"`
+	IgnoreDefaultAttentionSetRules bool           `json:"ignore_default_attention_set_rules"`
 }
 
 func postCommandMain() {
@@ -269,6 +270,9 @@ func postCommandMain() {
 		Labels: map[string]int{
 			"Verified": verified,
 		},
+
+		// Update the attention set if we are failing this patchset.
+		IgnoreDefaultAttentionSetRules: verified == 1,
 	}
 
 	body, _ := json.Marshal(review)