refactor(ops/pipelines): Move revision tagging into static pipeline r/3005

This makes the revision number available much earlier (before the rest
of the pipeline runs, while Nix eval is happening) which should only
be a few seconds after a commit to canon.

It is also more readable in this shape.

Change-Id: Iccbb17dfef6afe68f54fda41e8d10c4dc52b08c2
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3775
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>

1 files changed, 0 insertions, 14 deletions

diff --git a/ops/pipelines/depot.nix b/ops/pipelines/depot.nix
index 7c72098b9d5e..6d4b69d5b086 100644
--- a/ops/pipelines/depot.nix
+++ b/ops/pipelines/depot.nix
@@ -116,19 +116,5 @@ let
           allow_failure = false;
         }];
       })
-
-      # Create a revision number for the current commit for builds on
-      # canon.
-      #
-      # This writes data back to Gerrit using the Buildkite agent
-      # credentials injected through a git credentials helper.
-      #
-      # Revision numbers are defined as the number of commits in the
-      # lineage of HEAD, following only the first parent of merges.
-      ({
-        command = "git -c 'credential.helper=/etc/secrets/buildkite-credential-helper' push origin \"HEAD:refs/r/$(git rev-list --count --first-parent HEAD)\"";
-        label = ":git:";
-        "if" = ''build.branch == "refs/heads/canon"'';
-      })
     ];
 in (writeText "depot.yaml" (toJSON pipeline))