about summary refs log tree commit diff
path: root/ops/pipelines/depot.nix
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2021-12-14T16·20+0100
committerclbot <clbot@tvl.fyi>2021-12-14T17·02+0000
commit9f22b4f1c89a2932d6f797a7e1b7dbcae0ca73d2 (patch)
tree4e942255ad78081687c33897e8f994bb3ecf29e0 /ops/pipelines/depot.nix
parent15e3afccef649db98f8ed59a94244c21a537a37a (diff)
docs(ops/pipelines/depot): correct comment about fallback build cmd r/3240
We can gcroot the derivation files and drop this step, but have
elected not to do so for the moment, see cl/3436.

Change-Id: I993a1f3921e9f21e18fa260e76d3dd15ffa556bd
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4327
Tested-by: BuildkiteCI
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'ops/pipelines/depot.nix')
-rw-r--r--ops/pipelines/depot.nix7
1 files changed, 3 insertions, 4 deletions
diff --git a/ops/pipelines/depot.nix b/ops/pipelines/depot.nix
index 878526e37484..8d4f7d27578d 100644
--- a/ops/pipelines/depot.nix
+++ b/ops/pipelines/depot.nix
@@ -36,10 +36,9 @@ let
       # at least one of its `outPath`s, so we need to discard the string context
       # if we don't want to build everything during pipeline construction.
       "nix-store --realise '${drvPath}'"
-      # However, Nix doesn't track references of store paths to derivations, so
-      # there's no guarantee that the derivation file is not garbage collected.
-      # To handle this case we fall back to an ordinary build if the derivation
-      # file is missing.
+      # Since we don't gcroot the derivation files, they may be deleted by the
+      # garbage collector. In that case we can reevaluate and build the attribute
+      # using nix-build.
       "|| (test ! -f '${drvPath}' && nix-build -E '${mkBuildExpr target}' --show-trace)"
     ];
     label = ":nix: ${mkLabel target}";