diff options
author | Vincent Ambo <mail@tazj.in> | 2022-01-14T19·17+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2022-01-14T20·30+0000 |
commit | 058bf61193f166f34d3dc4b6629a691b70d43142 (patch) | |
tree | 4fbf995fbbd3c7a54fdf06365a0434111f3c7e79 /ops/gerrit-tvl/static | |
parent | ee52fbc46c4812921c5e68c16be2542e36d45366 (diff) |
fix(gerrit-tvl): Fix construction of ref used in Buildkite r/3593
... and remove a spammy log statement. This changed in besadii a while ago and lead to the behaviour of failing silently, instead of failing with an error saying "undefined undefined". Note that with this change merged the plugin probably still won't work again, but it gets us a step closer to the real error. Change-Id: I3db25d246f4b1c634d316cd92574e27fb220d769 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4887 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
Diffstat (limited to '')
-rw-r--r-- | ops/gerrit-tvl/static/tvl.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js index 470eb79d6689..2f8db90945ed 100644 --- a/ops/gerrit-tvl/static/tvl.js +++ b/ops/gerrit-tvl/static/tvl.js @@ -41,8 +41,8 @@ const tvlChecksProvider = { } const params = { - // besadii uses the patchset ref as the branch name. - branch: `refs/changes/${changeNumber.toString().slice(-2)}/${changeNumber}/${patchsetNumber}`, + // besadii groups different patchsets of the same CL under this fake ref + branch: `cl/${changeNumber.toString()}`, }; const url = `https://api.buildkite.com/v2/organizations/tvl/pipelines/depot/builds?${encodeParams(params)}`; const resp = await fetch(url, { @@ -115,7 +115,6 @@ const tvlChecksProvider = { checkRun.results = [result]; } - console.log(checkRun); runs.push(checkRun); } } |