about summary refs log tree commit diff
path: root/ops/buildkite
diff options
context:
space:
mode:
authorYureka <tvl@yuka.dev>2024-07-24T18·54+0200
committeryuka <tvl@yuka.dev>2024-07-25T09·52+0000
commit6a988a1598ac81a06454f9b18d36e4e3ac33cac6 (patch)
tree555a07379d27e5342cd11d23edcc7ec9230690d1 /ops/buildkite
parente97202e54a02d0717f0457fec0863e3e74fc93d8 (diff)
fix(tvix/castore/GRPCDirectorySvc): fix a bug in the get_recursive fn r/8412
When retrieving a closure with get_recursive, the following could happen in the GRPC client:
- The first reference to the deduplicated directory is added to expected_directory_digests
- The deduplicated directory is obtained removed from expected_directory_digests
- The second reference to the deduplicated directory is added to expected_directory_digests
- The deduplicated directory has already been sent, but is still in the
  expected_directory_digests. It looks to the GRPC client like the
  closure is incomplete and the stream ended prematurely.

Change-Id: Ic62bca12e7f8fb85af5fa4dacd199f0f3b8eea8c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12033
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'ops/buildkite')
0 files changed, 0 insertions, 0 deletions