diff options
| author | Evgeny Zemtsov <eze@resoptima.com> | 2022-10-10T11·20+0200 |
|---|---|---|
| committer | ezemtsov <eugene.zemtsov@gmail.com> | 2022-10-11T09·17+0000 |
| commit | b319e008313d68f2639de0f656d346ed9a823e41 (patch) | |
| tree | 8ca86426dddf61f2d7c8b4ad01220093cf9e5885 /nix | |
| parent | 1181bd78fc7d41a4786a0355244dbdee327560a7 (diff) | |
fix(nix/buildkite): split extra steps based on all known phases r/5104
Fix a bug introduced by 2ca153141 (I merged the wrong patchset). Issue happens when pipeline is split by phases into independent evals (e.g. build/release/deploy). Splitting extra steps requires knowledge of all known phases, otherwise pipeline evaluation fails due to extra steps from inactive phases. Change-Id: Iab0f2dc3eadda281e483055e26f00a95442e15b0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6942 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'nix')
| -rw-r--r-- | nix/buildkite/default.nix | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/nix/buildkite/default.nix b/nix/buildkite/default.nix index 834e4f7a42aa..f0f760b3ceb1 100644 --- a/nix/buildkite/default.nix +++ b/nix/buildkite/default.nix @@ -197,7 +197,7 @@ rec { # Split extra steps by phase. splitExtraSteps = lib.groupBy ({ phase, ... }: phase) - (attrValues (mapAttrs (normaliseExtraStep enabledPhases overridable) + (attrValues (mapAttrs (normaliseExtraStep phases overridable) (target.meta.ci.extraSteps or { }))); extraSteps = mapAttrs |