about summary refs log tree commit diff
path: root/mk
diff options
context:
space:
mode:
authorEelco Dolstra <eelco.dolstra@logicblox.com>2014-03-28T15·59+0100
committerEelco Dolstra <eelco.dolstra@logicblox.com>2014-03-28T15·59+0100
commit49009573bc2eacd823d57433daf1f59dfe415065 (patch)
tree7a8a15d1bc549e674f40cffdf0613de7af512b93 /mk
parent24cb65efc3c34e24fc653779a4d42cf4f31c6737 (diff)
Don't interpret strings as format strings
Ludo reported this error:

  unexpected Nix daemon error: boost::too_few_args: format-string refered to more arguments than were passed

coming from this line:

  printMsg(lvlError, run.program + ": " + string(err, 0, p));

The problem here is that the string ends up implicitly converted to a
Boost format() object, so % characters are treated specially.  I
always assumed (wrongly) that strings are converted to a format object
that outputs the string as-is.

Since this assumption appears in several places that may be hard to
grep for, I've added some C++ type hackery to ensures that the right
thing happens.  So you don't have to worry about % in statements like

  printMsg(lvlError, "foo: " + s);

or

  throw Error("foo: " + s);
Diffstat (limited to 'mk')
0 files changed, 0 insertions, 0 deletions