about summary refs log tree commit diff
path: root/maintainers
diff options
context:
space:
mode:
authorEelco Dolstra <edolstra@gmail.com>2018-08-08T19·39+0200
committerEelco Dolstra <edolstra@gmail.com>2018-08-08T19·39+0200
commita0b971dd9c19819d4f7a3a8ab102be9d7101e3e0 (patch)
tree2a1e14b55e07493a2663ffdc24d13f58229c8a9a /maintainers
parent103ad1598c4708735412ffbb4f8ef9730ec071d2 (diff)
S3BinaryCacheStore: Don't use the transfer status callback
This callback is executed on a different thread, so exceptions thrown
from the callback are not caught:

  Aug 08 16:25:48 chef hydra-queue-runner[11967]: terminate called after throwing an instance of 'nix::Error'
  Aug 08 16:25:48 chef hydra-queue-runner[11967]:   what():  AWS error: failed to upload 's3://nix-cache/19dbddlfb0vp68g68y19p9fswrgl0bg7.ls'

Therefore, just check the transfer status after it completes. Also
include the S3 error message in the exception.
Diffstat (limited to 'maintainers')
0 files changed, 0 insertions, 0 deletions