about summary refs log tree commit diff
path: root/emacs
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2020-02-17T22·35+0000
committerWilliam Carroll <wpcarro@gmail.com>2020-02-17T22·40+0000
commit2e63a4e2e1effca4ca605b45a0beb976a0df9dd0 (patch)
treeab80bd1df09941266f45705a52cc9b31d88c68b5 /emacs
parente61965cafd25ecc8b905feabd169204e3fb28e84 (diff)
Require keybindings.el after wpc-keybindings.el
keybindings.el calls (require 'evil-ex), which I introduced in this commit...
0456a1c4b4405da2681296b2250681454637d80f
...calling (require 'evil-ex) loads evil. When evil is loaded before
evil-want-integration is set to nil, evil-collection writes to *Warnings* when
Emacs initializes, which I find noisy. This commit ensures the
evil-want-integration is set to nil before evil is loaded, which appeases
evil-collection and thus removes the warning message.

Bonus:
If you git checkout the previous commit, and attempt to run the KBDs...
- `SPC g s`: magit-status
- `s h`: evil-window-vsplit
...from a buffer whose major-mode is dired-mode, you should notice that the
above functions won't execute.

Strangely though, if you look at this commit...
37f8ca04f29ea9bf988b2277c42f3e264d7a89e1
...I fixed these issues. Well I introduced a regression when I added 0456a1c.

My current guess is that when evil-collection complains about
evil-want-integration, it is breaking the evaluation sequence of my init.el
file. wpc-dired.el is downstream from wpc-keybindings.el, which requires
evil-collection. Perhaps no modules required after wpc-keybindings.el are
evaluated after evil-collection warns about evil-want-integration. Even if that
assumption is wrong, what I do know is that this commit fixes the
evil-collection warning and restores the KBDs for dired-mode-map.

Here's to feeding two birds with one scone!
Diffstat (limited to 'emacs')
-rw-r--r--emacs/.emacs.d/init.el2
1 files changed, 1 insertions, 1 deletions
diff --git a/emacs/.emacs.d/init.el b/emacs/.emacs.d/init.el
index 91fff6a720bc..fa5147206c17 100644
--- a/emacs/.emacs.d/init.el
+++ b/emacs/.emacs.d/init.el
@@ -35,8 +35,8 @@
 ;; (require 'egg-timer "~/programming/egg-timer.el/egg-timer.el")
 
 ;; TODO: Reconcile kbd.el, keybindings.el, wpc-keybindings.el, keyboard.el.
-(require 'keybindings)
 (require 'wpc-keybindings)
+(require 'keybindings)
 (require 'window-manager)
 (require 'wpc-ui)
 (require 'wpc-dired)