about summary refs log tree commit diff
path: root/emacs/.emacs.d/wpc/bookmark.el
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2020-09-02T13·09+0100
committerWilliam Carroll <wpcarro@gmail.com>2020-09-02T13·09+0100
commit4a6937106559892f601999a6f3cae9beff1fe5f1 (patch)
tree98bc85caf2bad8ea4780a57b29e000b61ca718f5 /emacs/.emacs.d/wpc/bookmark.el
parentdffb224023e3a663afc4b7461a94c0777fa8dd97 (diff)
General Elisp linting
TL;DR:
- Remove `require` statements from init.el
- Remove unused, auto-install KBDs for bookmark.el
- Remove unused `require` statements from clipboard
- Remove unused, commented-out code

I would like for an Elisp linting stage to test for unused `require` statements,
but I'm unsure how practical that is to support.
Diffstat (limited to 'emacs/.emacs.d/wpc/bookmark.el')
-rw-r--r--emacs/.emacs.d/wpc/bookmark.el7
1 files changed, 3 insertions, 4 deletions
diff --git a/emacs/.emacs.d/wpc/bookmark.el b/emacs/.emacs.d/wpc/bookmark.el
index 4d1a74e2e145..6384ba88b2b7 100644
--- a/emacs/.emacs.d/wpc/bookmark.el
+++ b/emacs/.emacs.d/wpc/bookmark.el
@@ -33,9 +33,6 @@
 
 (cl-defstruct bookmark label path kbd)
 
-(defconst bookmark-install-kbds? t
-  "When t, install keybindings.")
-
 ;; TODO: Consider hosting this function somewhere other than here, since it
 ;; feels useful above of the context of bookmarks.
 ;; TODO: Assess whether it'd be better to use the existing function:
@@ -82,7 +79,9 @@ Otherwise, open with `counsel-find-file'."
      ((f-file? path)
       (funcall bookmark-handle-file path)))))
 
-(when bookmark-install-kbds?
+
+(defun bookmark-install-kbds ()
+  "Install the keybindings defined herein."
   (->> bookmark-whitelist
        (list-map
         (lambda (b)