diff options
| author | Florian Klink <flokli@flokli.de> | 2023-08-19T11·17+0200 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2023-08-21T09·48+0000 |
| commit | 387a743944d72978db2d1c4f449cbbce76b7835f (patch) | |
| tree | 6fbb102c32d8ed7b17536338d68337d5a9ed0715 /docs | |
| parent | 778bd6894ba555d04a29ac01486d571a1299d0e3 (diff) | |
docs(docs/REVIEWS): explain disadvantages of patch submission r/6515
There's been some patch submissions gone wrong recently, and piling up in Gerrit. Describe a bit more why patch submission via email is less convenient for both sides. Change-Id: I9dfb5e912511a8b5b828f443c25d5cf36ec5acea Reviewed-on: https://cl.tvl.fyi/c/depot/+/9089 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/REVIEWS.md | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/docs/REVIEWS.md b/docs/REVIEWS.md index 930a15c8e74b..63d6b2c52460 100644 --- a/docs/REVIEWS.md +++ b/docs/REVIEWS.md @@ -138,9 +138,22 @@ instance, follow these instructions: 5. Submit the commit via email (see below). ## Submitting changes via email - -You can submit a patch via email to `depot@tvl.su` and it will be -added to Gerrit by a contributor. +Please keep in mind this process is more complicated and requires more work from +both sides: + + - Someone needs to relay potential comments from Gerrit to you, you won't get + emails from Gerrit. + - Uploading new revisions needs to be done by the person sending it to Gerrit + on your behalf. + - If you decide to get a Gerrit account later on, existing CLs need to be + abandoned and recreated (as CLs can't change Owner). + This causing earlier reviews do be more disconnected, causing more churn. + +We provide local accounts and do SSO with various third-parties, so getting the +account should usually be low-friction. + +If you still decide differently, you can submit a patch via email to +`depot@tvl.su` and it will be added to Gerrit by a contributor. Create an appropriate commit locally and send it us using either of these options: |