about summary refs log tree commit diff
path: root/docs
diff options
context:
space:
mode:
authorAdam Joseph <adam@westernsemico.com>2022-10-16T00·09-0700
committerclbot <clbot@tvl.fyi>2022-10-16T09·23+0000
commitd9c497520ca0b89f49aed7c9507504b55eff49ce (patch)
tree8441726dca0d67bd72162e0da39fbc135d02d2bf /docs
parentdb70c672cf05f78df791ebcb20fa97c4cb786515 (diff)
feat(tvix/eval): remove Clone instance from Chunk and Lambda r/5142
Lambda has a quite large and variable-sized runtime representation,
unlike Rc<Lambda>.  It would be easy to accidentally call clone() on
this and create input-dependent performance regressions.

Nothing in the codebase is currently using Lambda.clone().  Let's
remove the derived instance.  If it's really needed it is very easy
to add it back in, but whoever does that will have to look at the
struct they're adding Clone to, which will hopefully prompt them to
think about whether or not that's really what they want to do.

Change-Id: I7806a741862ab4402229839ce3f4ea75aafd6d12
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7029
Autosubmit: Adam Joseph <adam@westernsemico.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions