diff options
author | sterni <sternenseemann@systemli.org> | 2022-10-09T09·22+0200 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2022-10-09T13·25+0000 |
commit | 5174c2163730c683ca5c2a01be537c38173bab33 (patch) | |
tree | fc68079e00b37d69f917b6073651159459ef97ba /docs/REVIEWS.md | |
parent | 1e852098091dcaaaf3b9750c6dff5e465403f8c3 (diff) |
fix(nix/tag): correct no match check in discr r/5071
It uses discrDef internally, but passes `null` as the default tag name, causing Nix to drop the attribute and return an empty attribute set if the default case is hit. Consequently we need to check for the empty attribute set, not `null` to figure out if there was no match found. We can also test this behavior using `assertThrows` which was introduced after the tag library was originally written. Change-Id: I45adb2f9602762dfc867956323fb3f5ae4c8bd1d Reviewed-on: https://cl.tvl.fyi/c/depot/+/6904 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
Diffstat (limited to 'docs/REVIEWS.md')
0 files changed, 0 insertions, 0 deletions