diff options
| author | Florian Klink <flokli@flokli.de> | 2023-02-08T09·37+0100 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2023-02-08T10·39+0000 |
| commit | d4cbdc2beb0460918d9c358e1bc39a5dbaa67b09 (patch) | |
| tree | f533cc4d488a304e28bac3e6a0486cfc11ee0dfc /docs/REVIEWS.md | |
| parent | 5fa35d9d49572a8276cb044a6aa7d9a83308d9be (diff) | |
feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI r/5843
Nix accepts SRI hashes that are missing their padding characters in base64, as seen in https://github.com/NixOS/nixpkgs/blob/7e49471316373c471a3bf4b78c130ebc907ae2d2/pkgs/development/libraries/kerberos/krb5.nix . It only seems to work in the SRI case, not with `sha256` being set to a (nopad) base64 string. Add regression tests for this, and document why we don't want to support *additional* characters afterwards. Reported in https://b.tvl.fyi/issues/252 Change-Id: I9ffc2b417501b426ced1894a9cbf95ff5f0e5159 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8037 Reviewed-by: Alyssa Ross <hi@alyssa.is> Tested-by: BuildkiteCI
Diffstat (limited to 'docs/REVIEWS.md')
0 files changed, 0 insertions, 0 deletions