diff options
author | Adam Joseph <adam@westernsemico.com> | 2023-12-11T11·57-0800 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-12-12T14·54+0000 |
commit | 1ac57b0d1cdade99cd6cdf34211aa23e63db6f97 (patch) | |
tree | d4e50c627f6d06ec0889f42da2402a33ae89ccd2 /docs/REVIEWS.md | |
parent | 370137974526ef9af1f0d3496d17e4232e3babfe (diff) |
feat(tvix/eval): nonrecursive coerce_to_string() r/7176
After this commit, the only non-builtins uses of generators are: - coerce_to_string() uses generators::request_enter_lambda() - Thunk::force() uses generators::request_enter_lambda() That's it! Once those two are taken care of, GenCo can become an implementation detail of `builtins::BuiltinGen`. No more crazy nonlocal flow control within the interpreter: if you've got a GenCo floating around in your code it's because you're writing a builtin, which isn't part of the core interpreter. The interpreter won't need GenCos to talk to itself anymore. Technically generators::request_path_import() is also used by coerce_to_string(), but that's just because the io_handle happens to be part of the VM. There's no recursion-depth issue there, so the call doesn't need to go through the generator mechanism (request_path_import() doesn't call back to the interpreter!) Change-Id: I83ce5774d49b88fdafdd61160975b4937a435bb0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10256 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: Adam Joseph <adam@westernsemico.com>
Diffstat (limited to 'docs/REVIEWS.md')
0 files changed, 0 insertions, 0 deletions