Prefer start-process to shell-command

Without doing any benchmarking (break this naughty habit), I'm preferring to
call `start-process` instead of `shell-command` in my `wallpaper/set`
function. I noticed that the `shell-command` call was unnecessarily polluting my
`pstree` call when I debugging my randomly changing wallpaper bug.

I'm mostly likely going to change a few more `shell-command` calls to prefer
`start-process`.

1 files changed, 9 insertions, 2 deletions

diff --git a/configs/shared/.emacs.d/wpc/wallpaper.el b/configs/shared/.emacs.d/wpc/wallpaper.el
index 63548964b76d..841fe5428e7a 100644
--- a/configs/shared/.emacs.d/wpc/wallpaper.el
+++ b/configs/shared/.emacs.d/wpc/wallpaper.el
@@ -31,8 +31,15 @@
   "My preferred computer wallpapers.")
 
 (defun wallpaper/set (path)
-  "Set computer wallpaper to image at `PATH' using `feh` under-the-hood."
-  (shell-command (string/format "feh --bg-scale --no-fehbg %s" path)))
+  "Set computer wallpaper to image at `PATH' using `feh` under-the-hood.
+`PATH' can be absolute or relative since `f-expand' is called in the function
+  body to ensure feh can resolve the path."
+  (start-process "*feh<wallpaper/set>*"
+                 nil
+                 "feh"
+                 "--bg-scale"
+                 "--no-feh-bg"
+                 (f-expand path)))
 
 (defun wallpaper/whitelist-set (wallpaper)
   "Focuses the WALLPAPER in the `wallpaper/whitelist' cycle."