about summary refs log tree commit diff
path: root/absl/types
diff options
context:
space:
mode:
authorAbseil Team <absl-team@google.com>2017-09-24T15·20-0700
committerDerek Mauro <dmauro@google.com>2017-09-25T14·12-0400
commitcf6ab6bb2b800fae859ccc735f398d22a7336a00 (patch)
treeee16a94d16734d11f9e91518038e2712ca025433 /absl/types
parent53c239d1fc161975dad32c654e1f42c0ec42f547 (diff)
Changes imported from Abseil "staging" branch:
  - b527a3e4b36b644ac424e3c525b1cd393f6f6c40 Fix some typos in the usage examples by Jorg Brown <jorg@google.com>
  - 82be4a9adf3bb0ddafc0d46274969c99afffe870 Fix typo in optional.h comment. by Abseil Team <absl-team@google.com>
  - d6ee63bf8fc51fba074c23b33cebc28c808d7f07 Remove internal-only identifiers from code. by Daniel Katz <katzdm@google.com>
  - f9c3ad2f0d73f53b21603638af8b4bed636e79f4 Use easier understandable names for absl::StartsWith and ... by Abseil Team <absl-team@google.com>
  - 7c16c14fefee89c927b8789d6043c4691bcffc9b Add -Wno-missing-prototypes back to the LLVM copts. by Derek Mauro <dmauro@google.com>
  - 2f4b7d2e50c7023240242f1e15db60ccd7e8768d IWYU | absl/strings by Juemin Yang <jueminyang@google.com>
  - a99cbcc1daa34a2d6a2bb26de275e05173cc77e9 IWYU | absl/type by Juemin Yang <jueminyang@google.com>
  - 12e1146d0fc76c071d7e0ebaabb62f0a984fae66 Use LLVM_FLAGS and LLVM_TEST_FLAGS when --compiler=llvm. by Derek Mauro <dmauro@google.com>
  - cd6bea616abda558d0bace5bd77455662a233688 IWYU | absl/debugging by Juemin Yang <jueminyang@google.com>
  - d9a7382e59d46a8581b6b7a31cd5a48bb89326e9 IWYU | absl/synchronization by Juemin Yang <jueminyang@google.com>
  - 07ec7d6d5a4a666f4183c5d0ed9c342baa7b24bc IWYU | absl/numeric by Juemin Yang <jueminyang@google.com>
  - 12bfe40051f4270f8707e191af5652f83f2f750c Remove the RoundTrip{Float,Double}ToBuffer routines from ... by Jorg Brown <jorg@google.com>
  - eeb4fd67c9d97f66cb9475c3c5e51ab132f1c810 Adds conversion functions for converting between absl/tim... by Greg Miller <jgm@google.com>
  - 59a2108d05d4ea85dc5cc11e49b2cd2335d4295a Change Substitute to use %.6g formatting rather than 15/1... by Jorg Brown <jorg@google.com>
  - 394becb48e0fcd161642cdaac5120d32567e0ef8 IWYU | absl/meta by Juemin Yang <jueminyang@google.com>
  - 1e5da6e8da336699b2469dcf6dda025b9b0ec4c9 Rewrite atomic_hook.h to not use std::atomic<T*> under Wi... by Greg Falcon <gfalcon@google.com>

GitOrigin-RevId: b527a3e4b36b644ac424e3c525b1cd393f6f6c40
Change-Id: I14e331d91c956ef045ac7927091a9f179716de0c
Diffstat (limited to 'absl/types')
-rw-r--r--absl/types/BUILD.bazel4
-rw-r--r--absl/types/any_test.cc1
-rw-r--r--absl/types/optional.h7
-rw-r--r--absl/types/optional_test.cc2
-rw-r--r--absl/types/span_test.cc4
5 files changed, 8 insertions, 10 deletions
diff --git a/absl/types/BUILD.bazel b/absl/types/BUILD.bazel
index 8d09440ef104..f1e432d19a15 100644
--- a/absl/types/BUILD.bazel
+++ b/absl/types/BUILD.bazel
@@ -48,7 +48,7 @@ cc_library(
     hdrs = ["bad_any_cast.h"],
     copts = ABSL_EXCEPTIONS_FLAG + ABSL_DEFAULT_COPTS,
     features = [
-        "-use_header_modules",  # b/33207452
+        "-use_header_modules",
     ],
     deps = [
         "//absl/base",
@@ -153,7 +153,7 @@ cc_library(
     hdrs = ["bad_optional_access.h"],
     copts = ABSL_DEFAULT_COPTS + ABSL_EXCEPTIONS_FLAG,
     features = [
-        "-use_header_modules",  # b/33207452
+        "-use_header_modules",
     ],
     deps = [
         "//absl/base",
diff --git a/absl/types/any_test.cc b/absl/types/any_test.cc
index ab04bf5aac60..aef98f308241 100644
--- a/absl/types/any_test.cc
+++ b/absl/types/any_test.cc
@@ -16,7 +16,6 @@
 
 #include <initializer_list>
 #include <type_traits>
-#include <typeinfo>
 #include <utility>
 #include <vector>
 
diff --git a/absl/types/optional.h b/absl/types/optional.h
index 3e010bd5d0cf..8b56513fab2e 100644
--- a/absl/types/optional.h
+++ b/absl/types/optional.h
@@ -17,7 +17,7 @@
 // optional.h
 // -----------------------------------------------------------------------------
 //
-// This header file define the `absl::optional` type for holding a value which
+// This header file defines the `absl::optional` type for holding a value which
 // may or may not be present. This type is useful for providing value semantics
 // for operations that may either wish to return or hold "something-or-nothing".
 //
@@ -246,7 +246,7 @@ class optional_data_base : public optional_data_dtor_base<T> {
   }
 };
 
-// TODO(b/34201852): Add another base class using
+// TODO(absl-team) Add another class using
 // std::is_trivially_move_constructible trait when available to match
 // http://cplusplus.github.io/LWG/lwg-defects.html#2900, for types that
 // have trivial move but nontrivial copy.
@@ -502,7 +502,8 @@ class optional : private optional_internal::optional_data<T>,
   // the arguments `std::forward<Args>(args)...`  within the `optional`.
   // (The `in_place_t` is a tag used to indicate that the contained object
   // should be constructed in-place.)
-  // TODO(b/34201852): Add std::is_constructible<T, Args&&...> SFINAE.
+  //
+  // TODO(absl-team): Add std::is_constructible<T, Args&&...> SFINAE.
   template <typename... Args>
   constexpr explicit optional(in_place_t, Args&&... args)
       : data_base(in_place_t(), absl::forward<Args>(args)...) {}
diff --git a/absl/types/optional_test.cc b/absl/types/optional_test.cc
index 65f43871e1c0..645f5b93cf89 100644
--- a/absl/types/optional_test.cc
+++ b/absl/types/optional_test.cc
@@ -328,7 +328,7 @@ TEST(optionalTest, InPlaceConstructor) {
   static_assert(opt2->x == ConstexprType::kCtorInitializerList, "");
 #endif
 
-  // TODO(b/34201852): uncomment these when std::is_constructible<T, Args&&...>
+  // TODO(absl-team): uncomment these when std::is_constructible<T, Args&&...>
   // SFINAE is added to optional::optional(absl::in_place_t, Args&&...).
   // struct I {
   //   I(absl::in_place_t);
diff --git a/absl/types/span_test.cc b/absl/types/span_test.cc
index 22ea33e0a278..5a4f0014af38 100644
--- a/absl/types/span_test.cc
+++ b/absl/types/span_test.cc
@@ -14,7 +14,6 @@
 
 #include "absl/types/span.h"
 
-#include <algorithm>
 #include <array>
 #include <initializer_list>
 #include <numeric>
@@ -25,10 +24,9 @@
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
+#include "absl/base/attributes.h"
 #include "absl/base/config.h"
 #include "absl/base/internal/exception_testing.h"
-#include "absl/base/macros.h"
-#include "absl/base/port.h"
 #include "absl/container/fixed_array.h"
 #include "absl/container/inlined_vector.h"
 #include "absl/strings/str_cat.h"