diff options
| author | Abseil Team <absl-team@google.com> | 2018-12-26T17·31-0800 |
|---|---|---|
| committer | Gennadiy Civil <misterg@google.com> | 2018-12-26T17·35-0500 |
| commit | 01b471d9f3ebef27f5aaca14b66509099fa8cd6c (patch) | |
| tree | cb948c382a4aa5fdad1dca0d0ddbf2cc86b55415 /absl/strings | |
| parent | 7bd8f36c741c7cbe311611d7981bf38ba04c6fef (diff) | |
Export of internal Abseil changes.
-- ffe1bf0e5f98c77cf4193f24ae9ce94d16a72c6e by Alex Strelnikov <strel@google.com>: Remove accidental duplication of conanfile.py. PiperOrigin-RevId: 226926125 -- daf639ddd32c57d1c5ab99b26a9b15107f47ce16 by Derek Mauro <dmauro@google.com>: Fix the CMake build for absl::container. This target is deprecated and will be removed in the future. Fixes https://github.com/abseil/abseil-cpp/pull/238 PiperOrigin-RevId: 226921798 -- b8ab2bb9081c266ced1d966c86d5b19af6b5b3ef by Abseil Team <absl-team@google.com>: Cleanup: Fix some ClangTidy warnings. PiperOrigin-RevId: 226678127 -- 8cdc95316fc8baba00073c38a444c089ed2d5f5e by Abseil Team <absl-team@google.com>: Cleanup: Fix some ClangTidy warnings. PiperOrigin-RevId: 226567814 GitOrigin-RevId: ffe1bf0e5f98c77cf4193f24ae9ce94d16a72c6e Change-Id: Idfe30b8b3229082eb7db4bfa928d3257be7dce1a
Diffstat (limited to 'absl/strings')
| -rw-r--r-- | absl/strings/escaping.cc | 4 | ||||
| -rw-r--r-- | absl/strings/internal/str_format/bind.cc | 4 | ||||
| -rw-r--r-- | absl/strings/strip_test.cc | 3 |
3 files changed, 4 insertions, 7 deletions
diff --git a/absl/strings/escaping.cc b/absl/strings/escaping.cc index 8d8b00b2001c..29f55c7c3341 100644 --- a/absl/strings/escaping.cc +++ b/absl/strings/escaping.cc @@ -843,8 +843,8 @@ size_t Base64EscapeInternal(const unsigned char* src, size_t szsrc, char* dest, // Three bytes of data encodes to four characters of cyphertext. // So we can pump through three-byte chunks atomically. - if (szsrc >= 3) { // "limit_src - 3" is UB if szsrc < 3 - while (cur_src < limit_src - 3) { // as long as we have >= 32 bits + if (szsrc >= 3) { // "limit_src - 3" is UB if szsrc < 3. + while (cur_src < limit_src - 3) { // While we have >= 32 bits. uint32_t in = absl::big_endian::Load32(cur_src) >> 8; cur_dest[0] = base64[in >> 18]; diff --git a/absl/strings/internal/str_format/bind.cc b/absl/strings/internal/str_format/bind.cc index c4eddd17ddbe..758adb7a2569 100644 --- a/absl/strings/internal/str_format/bind.cc +++ b/absl/strings/internal/str_format/bind.cc @@ -25,12 +25,12 @@ class ArgContext { explicit ArgContext(absl::Span<const FormatArgImpl> pack) : pack_(pack) {} // Fill 'bound' with the results of applying the context's argument pack - // to the specified 'props'. We synthesize a BoundConversion by + // to the specified 'unbound'. We synthesize a BoundConversion by // lining up a UnboundConversion with a user argument. We also // resolve any '*' specifiers for width and precision, so after // this call, 'bound' has all the information it needs to be formatted. // Returns false on failure. - bool Bind(const UnboundConversion *props, BoundConversion *bound); + bool Bind(const UnboundConversion* unbound, BoundConversion* bound); private: absl::Span<const FormatArgImpl> pack_; diff --git a/absl/strings/strip_test.cc b/absl/strings/strip_test.cc index 40c4c6071211..67355fcbcfe4 100644 --- a/absl/strings/strip_test.cc +++ b/absl/strings/strip_test.cc @@ -27,9 +27,6 @@ namespace { -using testing::ElementsAre; -using testing::IsEmpty; - TEST(Strip, ConsumePrefixOneChar) { absl::string_view input("abc"); EXPECT_TRUE(absl::ConsumePrefix(&input, "a")); |