diff options
author | Abseil Team <absl-team@google.com> | 2017-10-05T20·33-0700 |
---|---|---|
committer | vslashg <gfalcon@google.com> | 2017-10-05T20·55-0400 |
commit | d732f2014bdd141135e6af06ee5b47e7fbe4b877 (patch) | |
tree | dd5083fd1250b9300d2cfa19e862efc455c18fbe /absl/container/inlined_vector.h | |
parent | cc4bed2d74f7c8717e31f9579214ab52a9c9c610 (diff) |
Changes imported from Abseil "staging" branch:
- d5a5960a133967e4af02836d304884cd6cbd6e46 Adjusting time tests for flakiness by Gennadiy Civil <misterg@google.com> - ccb8535fdc92c3c99bfa2795e75d3fbdcb134571 Internal-only tweak. by Jorg Brown <jorg@google.com> - 4c03dd9e54bd4645e7e7a8dfb3c590f5b0654884 Fix comment on some C++11 type traits backport. by Xiaoyi Zhang <zhangxy@google.com> - 43cd12d2304464163e33ae932fbb842a869213dd Allow intrinsic int128 to be set for __ppc64__ targets. by Abseil Team <absl-team@google.com> - 789e9c13de67ef3c7ba09c765c3484621897b6bb Update README.md description of 'types' library to be con... by Abseil Team <absl-team@google.com> - 8be10d7683c90b85244ddc67360a7ca2dfffdf01 Update comment on move constructors' noexcept specificati... by Xiaoyi Zhang <zhangxy@google.com> GitOrigin-RevId: d5a5960a133967e4af02836d304884cd6cbd6e46 Change-Id: I743efee47b9e65f46a44d9ab80ccd62cfd0c1301
Diffstat (limited to 'absl/container/inlined_vector.h')
-rw-r--r-- | absl/container/inlined_vector.h | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/absl/container/inlined_vector.h b/absl/container/inlined_vector.h index f060f5c5c40f..f68ca5074149 100644 --- a/absl/container/inlined_vector.h +++ b/absl/container/inlined_vector.h @@ -124,9 +124,24 @@ class InlinedVector { InlinedVector(const InlinedVector& v); InlinedVector(const InlinedVector& v, const allocator_type& alloc); + // This move constructor does not allocate and only moves the underlying + // objects, so its `noexcept` specification depends on whether moving the + // underlying objects can throw or not. We assume + // a) move constructors should only throw due to allocation failure and + // b) if `value_type`'s move constructor allocates, it uses the same + // allocation function as the `InlinedVector`'s allocator, so the move + // constructor is non-throwing if the allocator is non-throwing or + // `value_type`'s move constructor is specified as `noexcept`. InlinedVector(InlinedVector&& v) noexcept( absl::allocator_is_nothrow<allocator_type>::value || std::is_nothrow_move_constructible<value_type>::value); + + // This move constructor allocates and also moves the underlying objects, so + // its `noexcept` specification depends on whether the allocation can throw + // and whether moving the underlying objects can throw. Based on the same + // assumptions above, the `noexcept` specification is dominated by whether the + // allocation can throw regardless of whether `value_type`'s move constructor + // is specified as `noexcept`. InlinedVector(InlinedVector&& v, const allocator_type& alloc) noexcept( absl::allocator_is_nothrow<allocator_type>::value); |