diff options
author | Florian Klink <flokli@flokli.de> | 2023-05-23T11·15+0300 |
---|---|---|
committer | flokli <flokli@flokli.de> | 2023-05-25T05·06+0000 |
commit | 92b6d15da3ff7717d8d480fed4c31f68924656f8 (patch) | |
tree | 3ad9a4984c004cf697ad48ae5134662fd2aeb534 /OWNERS | |
parent | 24cbf93729d3ec202c690adc607364ab010e0c7c (diff) |
fix(tvix/store/bin): use spawn_blocking to call import_path r/6197
This operation is blocking, so it should be run inside a blocking tokio task. Tokio panics if it detects a blocking operation inside a non- blocking task, so cl/8619 would cause it to panic (as the GRPC clients use spawn_blocking under the hood). As spawn_blocking moves, and we can't clone `TvixStoreIO` (see cl/8614), we create a new instance of TvixStoreIO inside each loop iteration. Change-Id: I0c6548b3d4ac42d180d4c92314af8fd2b16510da Reviewed-on: https://cl.tvl.fyi/c/depot/+/8618 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
Diffstat (limited to 'OWNERS')
0 files changed, 0 insertions, 0 deletions