diff options
author | Vincent Ambo <mail@tazj.in> | 2022-08-31T01·42+0300 |
---|---|---|
committer | tazjin <tazjin@tvl.su> | 2022-09-07T19·08+0000 |
commit | fea7f90a7fa6024241cfc9bae7f8b9cc6e7ba13a (patch) | |
tree | cd6f1d4bf1e421628b3c3ef44dd8743c606627c1 /OWNERS | |
parent | 38d3db5fb88e85eae23680f1c892175e5dfaad0f (diff) |
fix(tvix/eval): thread Display & PartialEq through to thunk values r/4703
If a thunk is already evaluated, there are cases where due to the memoisation implementation something might observe a value wrapped in a thunk. In these cases, the implementation of `Display` and `PartialEq` must delegate to the underlying value. Note that there are a handful of other cases like these which we need to cover. It is a little tricky to write integration tests for these directly, especially as some of the open-upvalue optimisations coming down the pipe will reduce the number of observable thunks. One test that covers a part of this behaviour is currently disabled (needs some more machinery), but it's being brought back in the next commits. Change-Id: Iaa8cd338c12236af844bbc99d8cec2205f0d0095 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6370 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
Diffstat (limited to 'OWNERS')
0 files changed, 0 insertions, 0 deletions