diff options
author | Simon Hauser <simon.hauser@helsinki-systems.de> | 2024-06-11T10·30+0200 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-06-14T10·20+0000 |
commit | 118e69d81da73a4d55c6ab3ba7e1cc924bd3f506 (patch) | |
tree | 5508ae33d75f63b7af6315e07dbe046475734552 /LICENSE | |
parent | a857a2b978379ff0df66319a1eb6e1c1933cf11e (diff) |
fix(tvix/tracing): reduce the error logs of otlp if collector is offline r/8273
The problem is that opentelemetry_otlp tonic batch exporter tries to exports if either the `scheduled_delay` or if the `max_export_batch_size` is reached. Per default the `max_export_batch_size` is set to 512 spans, which means that we try to export these spans once that counter is reached. Each export will then try to connect to the exporter (if that not already happening) and will result in a `tcp connect error`. Increasing the max_export_batch_size to 4096 will then ensure that the export only happens if the `scheduled_delay` is met after the 10 seconds. `max_queue_size` is also increased, because `max_export_batch_size` should not be greater than `max_queue_size`, so similar to the default config its set to `max_export_batch_size * 4`. This will reduce the amount of tries to otlp if the collector is not available and otlp enabled. Change-Id: Ic3430006e8a104fa3b34d274678cae55b3620ce9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11791 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: Simon Hauser <simon.hauser@helsinki-systems.de>
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions