diff options
| author | sterni <sternenseemann@systemli.org> | 2022-02-04T11·15+0100 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2022-02-04T15·55+0000 |
| commit | a2ecd53f5822ae07fabfc7d2fac7fa929eb7f795 (patch) | |
| tree | ffcce1a3540e65bbc04adc0344c7a1c34501768c | |
| parent | 0e45761853cbde42001f85e361f407fe9d1afdd6 (diff) | |
chore: clean up some obsolete TODOs r/3768
* //3p/nix: probably not worth investing time into this anymore * //users/sterni/emacs: The emoji problem disappeared by itself with a newer emacs version, however a different one remains… * //web/panettone: If we ever want to change the behavior, we should just decide the behavior statically instead of using conditions and restarts, as we only call it in one place, so making different decisions depending on call sites is not really a use case we have. Change-Id: Iff9d439ce356db41ce34d690fb7b6a01822022fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/5223 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
| -rw-r--r-- | third_party/nix/src/libexpr/primops.cc | 1 | ||||
| -rw-r--r-- | users/sterni/emacs/init.el | 2 | ||||
| -rw-r--r-- | web/panettone/src/inline-markdown.lisp | 3 |
3 files changed, 1 insertions, 5 deletions
diff --git a/third_party/nix/src/libexpr/primops.cc b/third_party/nix/src/libexpr/primops.cc index 710d214ce7..f196c5ed72 100644 --- a/third_party/nix/src/libexpr/primops.cc +++ b/third_party/nix/src/libexpr/primops.cc @@ -1370,7 +1370,6 @@ static void prim_functionArgs(EvalState& state, const Pos& pos, Value** args, Value& v) { state.forceValue(*args[0]); if (args[0]->type == tPrimOpApp || args[0]->type == tPrimOp) { - // TODO(sterni): return set of formal arguments for fetch* primops state.mkAttrs(v, 0); return; } diff --git a/users/sterni/emacs/init.el b/users/sterni/emacs/init.el index 1cd9e9c36b..c75050b2cc 100644 --- a/users/sterni/emacs/init.el +++ b/users/sterni/emacs/init.el @@ -1,5 +1,5 @@ ;; Set default font and fallback font via set-fontset-font -;; TODO(sterni): Investigate non-emoji representation of some glyphs +;; TODO(sterni): Investigate why ZWJ sequences aren't shaped properly (let ((mono-font "Bitstream Vera Sans Mono-12") (emoji-font "Noto Color Emoji-12")) (setq default-frame-alist `((font . ,mono-font))) diff --git a/web/panettone/src/inline-markdown.lisp b/web/panettone/src/inline-markdown.lisp index fc5f77584f..e49293519b 100644 --- a/web/panettone/src/inline-markdown.lisp +++ b/web/panettone/src/inline-markdown.lisp @@ -124,7 +124,4 @@ ; only eliminates the slight use case for nesting :em inside :del, but ; shouldn't be too bad. As a side effect this is the precise behavior ; we want for :code. - ; - ; TODO(sterni): maybe bring back the restart-based system which allowed - ; to skip nested tokens if desired. (t (write-string (who:escape-string tok-str) target))))) |