about summary refs log tree commit diff
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2020-08-21T00·00+0100
committertazjin <mail@tazj.in>2020-08-21T00·37+0000
commit8893c30114822148c396eb1f116cd7e1a6f3f095 (patch)
tree1b0e89ed237278b037422ea6c3a169cbf4bea7e7
parent375c1c2a4efee962aa0f97e4b312ffb14c12d7e9 (diff)
chore(tvix): Add TODO comment for std::ostream in buildDerivation r/1695
Change-Id: I1e3b6abd4606d86f00ddaa8e2a1809f51e27126d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1823
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
-rw-r--r--third_party/nix/src/libstore/store-api.hh1
1 files changed, 1 insertions, 0 deletions
diff --git a/third_party/nix/src/libstore/store-api.hh b/third_party/nix/src/libstore/store-api.hh
index 91dd54cfe5..76c757bd69 100644
--- a/third_party/nix/src/libstore/store-api.hh
+++ b/third_party/nix/src/libstore/store-api.hh
@@ -467,6 +467,7 @@ class Store : public std::enable_shared_from_this<Store>, public Config {
   /* Build a single non-materialized derivation (i.e. not from an
      on-disk .drv file). Note that ‘drvPath’ is only used for
      informational purposes. */
+  // TODO(tazjin): Thread std::ostream through here, too.
   virtual BuildResult buildDerivation(const Path& drvPath,
                                       const BasicDerivation& drv,
                                       BuildMode buildMode) = 0;