about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAmineChikhaoui <amine.chikhaoui91@gmail.com>2018-05-07T13·27+0100
committerAmineChikhaoui <amine.chikhaoui91@gmail.com>2018-05-07T13·27+0100
commit591e75cd01f1650aab5538432a8637683ad1a9d0 (patch)
treea8b976a05855456459d08a6f4943de6cb76524c6
parent129394fb953475888173de5d8f864de3a2569e0e (diff)
add a FIXME note to find a way to abort the multipart uploads in
case the nix command is interrupted.
-rw-r--r--src/libstore/s3-binary-cache-store.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libstore/s3-binary-cache-store.cc b/src/libstore/s3-binary-cache-store.cc
index b55ff5c6d5d5..37da44da873c 100644
--- a/src/libstore/s3-binary-cache-store.cc
+++ b/src/libstore/s3-binary-cache-store.cc
@@ -296,8 +296,8 @@ struct S3BinaryCacheStoreImpl : public S3BinaryCacheStore
         transferConfig.uploadProgressCallback =
             [&](const TransferManager *transferManager,
                 const std::shared_ptr<const TransferHandle>
-                    &transferHandle)
-            {
+                    &transferHandle) {
+              //FIXME: find a way to properly abort the multipart upload.
               checkInterrupt();
               printTalkative("upload progress ('%s'): '%d' of '%d' bytes",
                              path,