about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-11-01T20·32+0000
committerclbot <clbot@tvl.fyi>2024-11-02T20·15+0000
commitf02bc522b66dda707a7ef469082e56fc0df46569 (patch)
treea31d55055aa71f1cd4b154e2a6e608fdae1bfcd2
parent37835634e8009381d6747ab01cbfc4134d637654 (diff)
docs(tvix/TODO): add Value::Json TODO r/8883
Change-Id: Id47c1e3f98cb0bf53006b002417b69cfa49b7410
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12721
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
-rw-r--r--tvix/docs/src/TODO.md9
1 files changed, 9 insertions, 0 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md
index 4db77b04d442..ff10b26cbf1d 100644
--- a/tvix/docs/src/TODO.md
+++ b/tvix/docs/src/TODO.md
@@ -10,6 +10,15 @@ Feel free to add new ideas. Before picking something, ask in `#tvix-dev` to make
 sure noone is working on this, or has some specific design in mind already.
 
 ## Cleanups
+### Evaluator
+ - There's not really a good reason why the `tvix_eval::Value::Json` enum kind
+   exists.
+  `builtins.toJSON` should simply produce a string with context, and everything
+   else should be a hidden implementation detail and should not be leaked to
+   `Value`.
+   This is a hack, as we wanted to use `serde_json` as is, but should be cleaned
+   up.
+
 ### Nix language test suite
  - Think about how to merge, but "categorize" `tvix_tests` in `glue` and `eval`.
    We currently only have this split as they need a different feature set /