diff options
| author | Marijan Petričević <marijan.petricevic94@gmail.com> | 2024-10-08T17·42-0500 |
|---|---|---|
| committer | Marijan Petričević <marijan.petricevic94@gmail.com> | 2024-10-09T14·08+0000 |
| commit | ae9ff35c32cbcfc865e651c92ddb5ad03158140b (patch) | |
| tree | d9b53e17195a41032da5174037955202bd92d969 | |
| parent | ac4a77d82f701c0cc9e13fd684133ef5405a93e1 (diff) | |
refactor(tvix/cli/args): remove log-level argument r/8782
RUST_LOG allows for a more granular tracing configuration Change-Id: Iea29fc2b154345eb7479dfd8bbea6abfd4716341 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12585 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
| -rw-r--r-- | tvix/cli/src/args.rs | 8 | ||||
| -rw-r--r-- | tvix/cli/src/main.rs | 1 | ||||
| -rw-r--r-- | tvix/docs/src/TODO.md | 3 |
3 files changed, 0 insertions, 12 deletions
diff --git a/tvix/cli/src/args.rs b/tvix/cli/src/args.rs index 36f9a6a262dd..d47258f10e26 100644 --- a/tvix/cli/src/args.rs +++ b/tvix/cli/src/args.rs @@ -1,7 +1,6 @@ use std::path::PathBuf; use clap::Parser; -use tracing::Level; use tvix_store::utils::ServiceUrlsMemory; /// Provides a CLI interface to trigger evaluation using tvix-eval. @@ -14,13 +13,6 @@ use tvix_store::utils::ServiceUrlsMemory; /// The CLI interface is not stable and subject to change. #[derive(Parser, Clone)] pub struct Args { - /// A global log level to use when printing logs. - /// It's also possible to set `RUST_LOG` according to - /// `tracing_subscriber::filter::EnvFilter`, which will always have - /// priority. - #[arg(long, default_value_t=Level::INFO)] - pub log_level: Level, - /// Path to a script to evaluate pub script: Option<PathBuf>, diff --git a/tvix/cli/src/main.rs b/tvix/cli/src/main.rs index 379dd915cbfb..0bac75e0f85e 100644 --- a/tvix/cli/src/main.rs +++ b/tvix/cli/src/main.rs @@ -53,7 +53,6 @@ fn main() { let args = Args::parse(); let _ = tvix_tracing::TracingBuilder::default() - .level(args.log_level) .enable_progressbar() .build() .expect("unable to set up tracing subscriber"); diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index 9f8feef9e3ac..7ed20758122a 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -262,9 +262,6 @@ This requires some more designing. Some goals: - Some work ongoing on the worker operation parsing (griff, picnoir) ### O11Y - - Maybe drop `--log-level` entirely, and only use `RUST_LOG` env exclusively? - `debug`,`trace` level across all crates is a bit useless, and `RUST_LOG` can - be much more granular… - Trace propagation for object_store once they support a way to register a middleware, so we can use that to register a tracing middleware. https://github.com/apache/arrow-rs/issues/5990 |