about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-09-01T13·20+0300
committerclbot <clbot@tvl.fyi>2024-09-03T15·17+0000
commitc60f4ccfda1b65bf8152b399e0087db87fa52b3d (patch)
tree9b43982253541e6556e6d2195294811dd667f2d6
parent7f1ecff98935291acabdbf5ad266278e0149483c (diff)
docs(tvix/contributing): remove reference to b/201 r/8645
This should be fixed with the switch to a "GitHub App" for
authentication.

Change-Id: I0bd8b4b9c9f53a754a12ce07f193d19f61f56014
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12414
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
-rw-r--r--tvix/docs/src/contributing/gerrit.md9
1 files changed, 3 insertions, 6 deletions
diff --git a/tvix/docs/src/contributing/gerrit.md b/tvix/docs/src/contributing/gerrit.md
index a9fdb75dec1a..3644e8cb0200 100644
--- a/tvix/docs/src/contributing/gerrit.md
+++ b/tvix/docs/src/contributing/gerrit.md
@@ -10,11 +10,9 @@ StackOverflow account.
 
 Additionally if you would prefer not to use an SSO option or wish to have a
 backup authentication strategy in the event of downed server or otherwise, we
-recommend setting up a TVL-specific LDAP account. Do note that our IdP
-(Keycloak) sometimes has [problems doing SSO with GitHub][github-problematic],
-so you might get an “unexpected error” while trying to sign in with GitHub;
-that error is not your fault. You can create that account by following these
-instructions:
+recommend setting up a TVL-specific LDAP account.
+
+You can create such an account by following these instructions:
 
 1. Checkout [TVL’s monorepo][check-out-monorepo] if you haven’t already
 2. Be a member of `#tvix-dev` (and/or `#tvl`) on [hackint][], a communication
@@ -107,7 +105,6 @@ system, as well as the other [attention set rules][attention-set-rules].
 [ops-users]: https://code.tvl.fyi/tree/ops/users/default.nix
 [hackint]: https://hackint.org
 [github-diff]: https://gerrit.wikimedia.org/r/Documentation/intro-gerrit-walkthrough-github.html
-[github-problematic]: https://b.tvl.fyi/issues/201
 [attention sets]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html
 [attention-set-rules]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html#_rules
 [^keycloak]: [^amend]: `git commit --amend`