diff options
| author | Florian Klink <flokli@flokli.de> | 2024-09-01T12·38+0300 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-09-01T13·19+0000 |
| commit | 7eb6900129d5bd358af2928155d9d6471b94e0db (patch) | |
| tree | 78d26bb0f4cceae9b77de62696969415ccb5df2f | |
| parent | ebf4647976857e574c8984d1b3580ae4343772e0 (diff) | |
fix(ops/keycloak): update client ID and client secret r/8634
This points to a "GitHub App" now
("https://github.com/organizations/tvlfyi/settings/apps"), rather than an
"OAuth App"
("https://github.com/organizations/tvlfyi/settings/applications").
Apparently this makes a big difference, and we should be using a "GitHub
App", not an "OAuth App".
The defails on why are in
https://github.com/keycloak/keycloak/issues/9429#issuecomment-1578953468
The App can be configured at
https://github.com/organizations/tvlfyi/settings/apps/tvl-keycloak .
With this, we should get rid of spurious Exceptions with some GitHub
users trying to log in, hopefully fixing https://b.tvl.fyi/issues/201.
Change-Id: I25d0d6cd1b05ad54ed3d760d3a48ce1f430c0e7d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12413
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
| -rw-r--r-- | ops/keycloak/user_sources.tf | 2 | ||||
| -rw-r--r-- | ops/secrets/tf-keycloak.age | bin | 962 -> 1135 bytes |
2 files changed, 1 insertions, 1 deletions
diff --git a/ops/keycloak/user_sources.tf b/ops/keycloak/user_sources.tf index f4207ba87bd9..7fa71e36fbb2 100644 --- a/ops/keycloak/user_sources.tf +++ b/ops/keycloak/user_sources.tf @@ -36,7 +36,7 @@ resource "keycloak_ldap_user_federation" "tvl_ldap" { resource "keycloak_oidc_identity_provider" "github" { alias = "github" provider_id = "github" - client_id = "6d7f8bb2e82bb6739556" + client_id = "Iv23liXfGNIr7InMg5Uo" client_secret = var.github_client_secret realm = keycloak_realm.tvl.id backchannel_supported = false diff --git a/ops/secrets/tf-keycloak.age b/ops/secrets/tf-keycloak.age index 237b9377bd79..7d470a6a304e 100644 --- a/ops/secrets/tf-keycloak.age +++ b/ops/secrets/tf-keycloak.age Binary files differ |