diff options
author | Florian Klink <flokli@flokli.de> | 2024-08-17T17·03+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-08-17T20·36+0000 |
commit | 76839683a7ab0453afcdc3374a5cc80cca2f9510 (patch) | |
tree | 04a5449e40109c9535403f61191431cda00b0d21 | |
parent | c75b0d08ce8fcf6f1e21fc090b2c4541575c485f (diff) |
fix(tvix/boot): workaround test flakiness r/8510
The boot tests are sometimes flaky, and we don't want them to periodically fail other build. Have Buildkite auto-retry them 2 times on failure. Logs for individual failures are still available, so it won't hinder flakiness debuggability. See https://buildkite.com/docs/pipelines/command-step#retry-attributes for a documentation of a parameter, and cl/8983 for the introduction of that feature to //nix/buildkite. Change-Id: I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12228 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
-rw-r--r-- | tvix/boot/tests/default.nix | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tvix/boot/tests/default.nix b/tvix/boot/tests/default.nix index 7b9fbbbf8c57..d078287a7b9b 100644 --- a/tvix/boot/tests/default.nix +++ b/tvix/boot/tests/default.nix @@ -119,6 +119,14 @@ let grep "${assertVMOutput}" output.txt ''; requiredSystemFeatures = [ "kvm" ]; + # HACK: The boot tests are sometimes flaky, and we don't want them to + # periodically fail other build. Have Buildkite auto-retry them 2 times + # on failure. + # Logs for individual failures are still available, so it won't hinder + # flakiness debuggability. + meta.ci.buildkiteExtraStepArgs = { + retry.automatic = true; + }; } // lib.optionalAttrs (isClosure && !useNarBridge) { __structuredAttrs = true; exportReferencesGraph.closure = [ path ]; |