diff options
| author | Florian Klink <flokli@flokli.de> | 2024-06-14T15·30+0300 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-06-15T04·02+0000 |
| commit | 86928b5e7f7a6e19035ffc55ca70f419ab470cfb (patch) | |
| tree | c82c000ee34ab54f4ed266e4746f118b925a0619 | |
| parent | 6e321c615c74ed151124f677597e5e2d25e07431 (diff) | |
docs(tvix/TODO): add builtins.path roundtrip for flat r/8278
Change-Id: I8291d2fdfa2ea31ec24c82dcfb447fa9eaa3a961 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11819 Reviewed-by: Connor Brewster <cbrewster@hey.com> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
| -rw-r--r-- | tvix/docs/src/TODO.md | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index 1f020e58c913..d667a6540e53 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -115,6 +115,15 @@ Some more fetcher-related builtins need work: - `fetchTree` (hairy, seems there's no proper spec and the URL syntax seems subject to change/underdocumented) +### `builtins.path` roundtrip for flat +`builtins.path` currently uses `filtered_ingest` also for the non-recursive +case, then reads through the blob contents again to get the sha256. + +We should take care of assembling the root node on our own, and pipe the data +through sha256 too (via `InspectReader`, see `glue/fetcher` for an example). + +This avoids some roundtrips, and is probably faster. + ### Derivation -> Build While we have some support for `structuredAttrs` and `fetchClosure` (at least enough to calculate output hashes, aka produce identical ATerm), the code |